Fix undefined behaviour in number serialisation. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When optimising, the compiler is allowed to reorder the read calls
in the following code:
return (uint16_t)read_uint8_t(info) |
((uint16_t)read_uint8_t(info) << 8);
Since read_uint8_t() has side effects, this could read a totally
wrong value and has to be rewritten as such:
uint16_t value = (uint16_t)read_uint8_t(info);
value |= (uint16_t)read_uint8_t(info) << 8;
return value;
This bug has been observed with Visual Studio 2019.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When optimising, the compiler is allowed to reorder the read calls
in the following code:
Since read_uint8_t() has side effects, this could read a totally
wrong value and has to be rewritten as such:
This bug has been observed with Visual Studio 2019.